forked from kiwitcms/kiwitcms.github.io
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Source update #1
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- moving files & adjusting paths as necessary - remove the local copy of FontAwesome b/c the new styles use LineAwesome
- update text & links as necessary - remove duplicated images - remove unused JavaScript video functions & reuse existing ones
reverts back to the previous script that we had b/c tiny-slider seems to be buggy and doesn't play well with Firefox
will be replaced with a link to YouTube in the footer
- move files which we want to keep into relevant directories - remove everything else
we don't need the minifyNav() function - keep the navigation size constant when scrolling.
replace --usable-width (undefined) with --usable-area
since GDPR we don't have embedded MC forms anywhere on the site. This is a left-over from earlier.
- this will avoid duplication of menu items & possible mismatch - also handle the selection of the active menu item based on the current page
it looks like HTML include is still not possible in Pelican, see getpelican/pelican#2783
- FontAwesome -> LineAwesome - add back color & other styles - template adds surrounding <section> tags where necessary
- navigation bar is full width now - sublists in <details> have different styles - logos now don't overflow and break on mobile - some cleanup in the file
NOTE: Links under navigation on hover get dark green background and dark-green text and I'm not able to properly override the inherited styles. The dark-green text of the link comes from the styles for the other items in the navigation links which are green on white background.
- navigation bar is full width now - sublists in <details> have different styles - logos now don't overflow and break on mobile
- animate hover - fixed positioning in CTA `todo:` `- fix big button icon size on mobile` `- fix image alignment and size in logo sections`
also make customer logos 150x150
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.