Allow running ambassador as a non-privileged user #524
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit lets ambassador to be run as a non-root user and moves all ambassador related configurations to /ambassador inside the container. Fix #457
concaf
force-pushed
the
concaf/fix/non-root-dockerfile
branch
from
fe09efe to
7f55325
Compare
|
@kflynn fixed the tests |
|
End-to-end tests need to pass too. I suspect that this may just be a matter of updating the |
|
(The code changes look reasonable. :) ) |
This commit changes the `targetPort: 80` entry throughout the project for the ambassador service to `targetPort: 8080` so as to support the changes done to run ambassador as a non-privileged user.
concaf
force-pushed
the
concaf/fix/non-root-dockerfile
branch
from
24f8eec to
67fea77
Compare
|
@kflynn e2e pass now |
LukeShu
pushed a commit
that referenced
this pull request
Mar 19, 2019
Allow running ambassador as a non-privileged user
LukeShu
pushed a commit
that referenced
this pull request
Mar 31, 2019
Allow running ambassador as a non-privileged user
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit lets ambassador to be run as a non-root user and
moves all ambassador related configurations to /ambassador
inside the container.
Fix #457