Better error messages #435
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
francescalb
reviewed
Aug 3, 2022
Changed argument to prefix in get_by_label and get_by_label_all when only entities from a given ontology with a given prefix are desired. The prefix is currently being compared to entity._namspace.name but a solution for prefix should be implemented.
where the entity is from and not the name of the namespace as given in owldreay2
be adressed separately. Test will fail.
Co-authored-by: Francesca L. Bleken <[email protected]>
World.get_unabbreviated_triples()
francescalb
approved these changes
Aug 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Added ontology path/URL to error messages when loading an ontology fails. Should hopefulle simplify debugging.
The tests should succeed when PR #436 has been merged...
Type of change:
Checklist:
This checklist can be used as a help for the reviewer.
Comments: