Added --ignore-namespace to emmocheck #60
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emmo/emmocheck.py
Outdated
| @@ -281,6 +283,10 @@ def main(): | |||
| parser.add_argument( | |||
| '--url-from-catalog', '-u', action='store_true', | |||
| help=('Get url from catalog file')) | |||
| parser.add_argument( | |||
| '--ignore-namespace', '-in', action='append', default=[], | |||
There was a problem hiding this comment.
Unusual with 2-letter short option. Normally -in is a shortcut for "-i -n" if "-i" doesn't take an argument or "-i n" if "-i" takes an argument. Alternative short options could be -g or -n.
There was a problem hiding this comment.
thank you, this is fixed
Contains a lot of print for testing
|
Works for skipping namespace check for 'emmocheck --check-imported --ignore-namespace=emmo-inferred emmo-inferred'. However namespace check for emmo does not go into the check at all because when onto = get_ontolog('emmo').load() all of the following are empty: onto.classes(), onto.object_properties(), onto.data_properties(), onto.individuals(), onto.annotation_properties(). Is this correct behaviour? |
Also check that the iri of the entities match the module base_iri
…O-python into emmocheck-ignore-namespace
…O-python into emmocheck-ignore-namespace
jesper-friis
approved these changes
Nov 1, 2020
…O-python into emmocheck-ignore-namespace
francescalb
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is now possible to ignore the a given namespace by:
emmocheck --ignore-namespace=http://emmo.info/emmo/emmo-inferred# emmo-inferred
However, this is not the same as ignoring submodules so does not work correctly yet. When you load an ontology, the base_iri is the same for the whole ontology...