Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added DOI badge #606

Merged
merged 2 commits into from
May 26, 2023
Merged

Added DOI badge #606

merged 2 commits into from
May 26, 2023

Conversation

jesper-friis
Copy link
Collaborator

Description

Type of change

  • Bug fix.
  • New feature.
  • Documentation update.
  • Test update.

Checklist

This checklist can be used as a help for the reviewer.

  • Is the code easy to read and understand?
  • Are comments for humans to read, not computers to disregard?
  • Does a new feature has an accompanying new test (in the CI or unit testing schemes)?
  • Has the documentation been updated as necessary?
  • Does this close the issue?
  • Is the change limited to the issue?
  • Are errors handled for all outcomes?
  • Does the new feature provide new restrictions on dependencies, and if so is this documented?

Comments

@jesper-friis jesper-friis requested a review from francescalb May 24, 2023 14:31
@codecov
Copy link

codecov bot commented May 24, 2023

Codecov Report

Merging #606 (0c992ad) into master (3190138) will decrease coverage by 0.04%.
The diff coverage is n/a.

❗ Current head 0c992ad differs from pull request most recent head 9906881. Consider uploading reports for the commit 9906881 to get more accurate results

@@            Coverage Diff             @@
##           master     #606      +/-   ##
==========================================
- Coverage   67.94%   67.91%   -0.04%     
==========================================
  Files          16       16              
  Lines        3135     3135              
==========================================
- Hits         2130     2129       -1     
- Misses       1005     1006       +1     

see 1 file with indirect coverage changes

@francescalb francescalb merged commit 6fa3427 into master May 26, 2023
@francescalb francescalb deleted the doi-badge branch May 26, 2023 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants