Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Item access to classes #613

Merged
merged 5 commits into from
Jun 5, 2023
Merged

Item access to classes #613

merged 5 commits into from
Jun 5, 2023

Conversation

jesper-friis
Copy link
Collaborator

@jesper-friis jesper-friis commented Jun 2, 2023

Description

Added item access, assignment and deletion to classes.

For now only annotation properties are supported. Rationale:

  • only annotations are directly related to a class - all other properties are restrictions
  • is_a, equivalent_to, disjoint_unions, disjoints, ... could be supported. But how do do the selection? And what is the added value compared to access these as attributes or methods directly?

Type of change

  • Bug fix.
  • New feature.
  • Documentation update.
  • Test update.

Checklist

This checklist can be used as a help for the reviewer.

  • Is the code easy to read and understand?
  • Are comments for humans to read, not computers to disregard?
  • Does a new feature has an accompanying new test (in the CI or unit testing schemes)?
  • Has the documentation been updated as necessary?
  • Does this close the issue?
  • Is the change limited to the issue?
  • Are errors handled for all outcomes?
  • Does the new feature provide new restrictions on dependencies, and if so is this documented?

Comments

@jesper-friis jesper-friis requested a review from francescalb June 2, 2023 17:34
@codecov
Copy link

codecov bot commented Jun 2, 2023

Codecov Report

Merging #613 (1dfecf9) into master (c28d8a4) will increase coverage by 0.17%.
The diff coverage is 100.00%.

❗ Current head 1dfecf9 differs from pull request most recent head 8e286b4. Consider uploading reports for the commit 8e286b4 to get more accurate results

@@            Coverage Diff             @@
##           master     #613      +/-   ##
==========================================
+ Coverage   68.14%   68.31%   +0.17%     
==========================================
  Files          16       16              
  Lines        3158     3172      +14     
==========================================
+ Hits         2152     2167      +15     
+ Misses       1006     1005       -1     
Impacted Files Coverage Δ
ontopy/patch.py 65.30% <100.00%> (+3.65%) ⬆️

... and 1 file with indirect coverage changes

@jesper-friis jesper-friis changed the title Item access to Thing's Item access to classes Jun 3, 2023
Copy link
Collaborator

@francescalb francescalb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks nice

@francescalb francescalb enabled auto-merge June 5, 2023 14:19
@francescalb francescalb merged commit 64b8e4e into master Jun 5, 2023
@francescalb francescalb deleted the item-access-for-things branch June 5, 2023 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants