-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow controling ontology IRI when saving #700
Conversation
Allow separating the IRI of the ontology from base_iri when saving using rdflib.
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #700 +/- ##
==========================================
- Coverage 71.30% 71.27% -0.03%
==========================================
Files 16 16
Lines 3394 3405 +11
==========================================
+ Hits 2420 2427 +7
- Misses 974 978 +4 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good. I have only one suggestion, which is to remove the file you create if it is there already.
See the comments.
Co-authored-by: Francesca L. Bleken <[email protected]>
Co-authored-by: Francesca L. Bleken <[email protected]>
Description
Allow separating the IRI of the ontology from
base_iri
when saving using rdflib.Unfortunately owlready2 doesn't allow to separate the IRI of the ontology from the
base_iri
(the namespace of the entities in the ontology). In many ontologies, e.g. EMMO, are these not the same.Further work: Also assign the ontology IRI when loading an ontology.
An even better solution would be to ask Jean-Baptiste to add support for separate ontology
iri
andbase_iri
to Owlready2.Type of change
Checklist
This checklist can be used as a help for the reviewer.
Comments