Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copy EMMO annotations #733

Merged
merged 5 commits into from
Mar 22, 2024
Merged

Copy EMMO annotations #733

merged 5 commits into from
Mar 22, 2024

Conversation

jesper-friis
Copy link
Collaborator

Description

Renamed option --copy-preflabel to --copy-emmo-annotations and more content to what it alias.

The intention with this option is to make it easy to publish EMMO-based ontologies that are understood by standard tools (including FOOPS).

Type of change

  • Bug fix.
  • New feature.
  • Documentation update.
  • Test update.

Checklist

This checklist can be used as a help for the reviewer.

  • Is the code easy to read and understand?
  • Are comments for humans to read, not computers to disregard?
  • Does a new feature has an accompanying new test (in the CI or unit testing schemes)?
  • Has the documentation been updated as necessary?
  • Does this close the issue?
  • Is the change limited to the issue?
  • Are errors handled for all outcomes?
  • Does the new feature provide new restrictions on dependencies, and if so is this documented?

Comments

Copy link

codecov bot commented Mar 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.21%. Comparing base (c299d23) to head (33ac540).

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #733      +/-   ##
==========================================
+ Coverage   72.18%   72.21%   +0.02%     
==========================================
  Files          17       17              
  Lines        3462     3462              
==========================================
+ Hits         2499     2500       +1     
+ Misses        963      962       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@francescalb francescalb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good

@jesper-friis jesper-friis merged commit 052ed1e into master Mar 22, 2024
12 checks passed
@jesper-friis jesper-friis deleted the copy-emmo-annotations branch March 22, 2024 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants