Make it possible to run HermiT on EMMO #740
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
francescalb
reviewed
Apr 15, 2024
ontopy/ontology.py
Outdated
Comment on lines
945
to
947
| filepath = os.path.join( | ||
| dir, file if isinstance(file, str) else file.name | ||
| ) |
There was a problem hiding this comment.
why? If I revert this, tests pass without problem.
There was a problem hiding this comment.
Add fix: isinstance(file, str) -> isinstance(file, (str, Path))
|
We should have a test on this. It is important that we wuickly pick up if running sync_reasoner on EMMO does not work. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #740 +/- ##
==========================================
- Coverage 72.21% 72.14% -0.07%
==========================================
Files 17 17
Lines 3462 3486 +24
==========================================
+ Hits 2500 2515 +15
- Misses 962 971 +9 ☔ View full report in Codecov by Sentry. |
francescalb
approved these changes
Apr 15, 2024
francescalb
added a commit
that referenced
this pull request
May 8, 2024
# Description Make it possible to run HermiT on EMMO, by: * Add support for additional keyword arguments that `sync_reasoner()` may pass to the `save()` method. * Remove custom datatypes before running HermiT. Readd the removed data properties after HermiT completes. * Add `--java-executable` and `--java-memory` arguments to ontoconvert to control how to run java. ## Type of change - [x] Bug fix. - [ ] New feature. - [ ] Documentation update. - [ ] Test update. Co-authored-by: francescalb <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Make it possible to run HermiT on EMMO, by:
sync_reasoner()may pass to thesave()method.--java-executableand--java-memoryarguments to ontoconvert to control how to run java.Type of change
Checklist
This checklist can be used as a help for the reviewer.
Comments