Added test for descriptions #766
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #766 +/- ##
==========================================
- Coverage 73.16% 72.54% -0.62%
==========================================
Files 18 18
Lines 3678 3701 +23
==========================================
- Hits 2691 2685 -6
- Misses 987 1016 +29 ☔ View full report in Codecov by Sentry. |
francescalb
reviewed
Jun 3, 2024
emmopy/emmocheck.py
Outdated
Comment on lines
191
to
192
| A description is either an elucidation, a definition or a | ||
| conceptualisation. |
There was a problem hiding this comment.
Suggested change
| A description is either an elucidation, a definition or a | |
| conceptualisation. | |
| A description is either an EMMO.elucidation, an EMMO.definition or an | |
| EMMO.conceptualisation. |
francescalb
reviewed
Jun 3, 2024
emmopy/emmocheck.py
Outdated
Comment on lines
205
to
206
| "ontology has no description (elucidation, definition or " | ||
| "conceptualisation)" |
There was a problem hiding this comment.
Suggested change
| "ontology has no description (elucidation, definition or " | |
| "conceptualisation)" | |
| "ontology has no description (EMMO.elucidation, EMMO.definition or " | |
| "EMMO.conceptualisation)" |
francescalb
reviewed
Jun 3, 2024
emmopy/emmocheck.py
Outdated
| with self.subTest(entity=entity, label=label): | ||
| self.assertTrue( | ||
| hasattr(entity, "elucidation"), | ||
| msg="no 'elucidation' in ontology", |
There was a problem hiding this comment.
Suggested change
| msg="no 'elucidation' in ontology", | |
| msg="no 'elucidation' in ontology", |
Suggested change
| msg="no 'elucidation' in ontology", | |
| msg=f"{entity} has no 'EMMO.elucidation' ", |
francescalb
reviewed
Jun 3, 2024
emmopy/emmocheck.py
Outdated
| ) | ||
| self.assertTrue( | ||
| hasattr(entity, "definition"), | ||
| msg="no 'definition' in ontology", |
There was a problem hiding this comment.
Suggested change
| msg="no 'definition' in ontology", | |
| msg=f"{entity} has no 'EMMO.definition'", |
francescalb
reviewed
Jun 3, 2024
emmopy/emmocheck.py
Outdated
| ) | ||
| self.assertTrue( | ||
| hasattr(entity, "conceptualisation"), | ||
| msg="no 'conceptualisation' in ontology", |
There was a problem hiding this comment.
Suggested change
| msg="no 'conceptualisation' in ontology", | |
| msg=f"{entity} has no 'conceptualisation'", |
francescalb
reviewed
Jun 3, 2024
emmopy/emmocheck.py
Outdated
Comment on lines
235
to
236
| msg="missing description (elucidation, deinition and/or " | ||
| f"conceptualidation): {label}", |
There was a problem hiding this comment.
Suggested change
| msg="missing description (elucidation, deinition and/or " | |
| f"conceptualidation): {label}", | |
| msg="missing description (EMMO.elucidation, EMMO.definition and/or " | |
| f"EMMO.conceptualidation): {label}", |
francescalb
reviewed
Jun 3, 2024
emmopy/emmocheck.py
Outdated
| ) | ||
| self.assertTrue( | ||
| len(entity.elucidation) < 2, | ||
| msg=f"more than one elucidation for {label}", |
There was a problem hiding this comment.
Suggested change
| msg=f"more than one elucidation for {label}", | |
| msg=f"more than one EMMO.elucidation for {label}", |
francescalb
reviewed
Jun 3, 2024
emmopy/emmocheck.py
Outdated
| ) | ||
| self.assertTrue( | ||
| len(entity.definition) < 2, | ||
| msg=f"more than one definition for {label}", |
There was a problem hiding this comment.
Suggested change
| msg=f"more than one definition for {label}", | |
| msg=f"more than one EMMO.definition for {label}", |
francescalb
reviewed
Jun 3, 2024
emmopy/emmocheck.py
Outdated
| ) | ||
| self.assertTrue( | ||
| len(entity.conceptualisation) < 2, | ||
| msg=f"more than one conceptualisation for {label}", |
There was a problem hiding this comment.
Suggested change
| msg=f"more than one conceptualisation for {label}", | |
| msg=f"more than one EMMO.conceptualisation for {label}", |
francescalb
approved these changes
Jun 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added test for that entities should be described. We require that a entities should have at least a elucidation, definition or conceptualisation. In addition we require that each of them can max be provided once.
Also update ontoconvert to include conceptualisations the
--copy-emmo-annotationsoption.Tested against EMMO during development, but no additional EMMO-dependent test has been added to the EMMOntoPy repo.
Type of change
Checklist
This checklist can be used as a help for the reviewer.
Comments