Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parse ignored topics as empty list when the field is empty #37

Open
wants to merge 1 commit into
base: development
Choose a base branch
from

Conversation

dogtopus
Copy link

@dogtopus dogtopus commented Feb 3, 2021

Also prevent the ignore condition being unnecessarily checked multiple times.

Also prevent the ignore condition being unnecessarily checked multiple times.
@emontnemery
Copy link
Owner

Can you explain what problem this solves?

@dogtopus
Copy link
Author

dogtopus commented Apr 19, 2021

If Mode4 is an empty string, ignoredtopics will be an empty string and breaks the check later. It will ignore everything instead of nothing which doesn't seem to be desired behavior. Also setting Mode4 to a, (with a trailing comma) does similar thing.

The other change was just to prevent the field from being checked multiple times and pollute the log.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants