Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

styled-system is not working with emotion 8.0.2-7 #351

Closed
tkh44 opened this issue Sep 27, 2017 · 0 comments · Fixed by #352
Closed

styled-system is not working with emotion 8.0.2-7 #351

tkh44 opened this issue Sep 27, 2017 · 0 comments · Fixed by #352
Assignees
@tkh44

Comments

@tkh44
Copy link
Member

tkh44 commented Sep 27, 2017

  • emotion version: 8.0.2-7
  • react version:

Relevant code.



What you did:


What happened:



Reproduction:

If an interpolation is a function that returns null, its currently being missed.

image

image



Problem description:


Suggested solution:

      		
    

      
  





        



            

              
            

        

      


      
    








      

    



      

  
            

    

      
    

    


      

          @tkh44
tkh44




              self-assigned this


      Sep 27, 2017

    

  



  


  
    
  
  

    
  tkh44 

      pushed a commit
      that referenced
      this issue

    
      Sep 27, 2017
    
    

      


  

    

      


  

  





      

        
          Check for null when evaluating input strings in createStyles
        

          
            
          

      


      

          

    
    
    

  

      


      

      


      
      

        
          284c5db
        
      

    

  

    

      
closes #351

    




    

  




  

  

    
  


  

      

    @tkh44
tkh44



    mentioned this issue
    
      Sep 27, 2017
    





  


  

      
   Merged

  







  




    

    


  


  
    
  
  

    
  tkh44 

      pushed a commit
      that referenced
      this issue

    
      Sep 27, 2017
    
    

      


  

    

      


  

  





      

        
          Check for null when evaluating input strings in createStyles (#352)
        

          
            
          

      


      

          

    
    
    

  

      


      

      


      
      

        
          03a1b04
        
      

    

  

    

      
* Check for null when evaluating input strings in createStyles

closes #351

* Update snapshots

    




    

  













  
  

    

      

  





  




  
  

              

  
    Sign up for free
    to join this conversation on GitHub.
    Already have an account?
    Sign in to comment


  



  






  
                  




    

  


      
  

    Assignees
  



        

      

        

  
      @tkh44
  
    tkh44
    

      








      


  


  

    Labels
  



    

    None yet







      

  

    

        

    Projects
  


        




    None yet




  



      


  

    
  

    Milestone
  


      No milestone





    
      
          
  

    

      

        
          

            
    

    Development
  




              
  
Successfully merging a pull request may close this issue.





    


  
          
      Check for null when evaluating input strings in createStyles

    
      emotion-js/emotion
    





        
      

    

  


      

    

  
      

  

    

      1 participant
    

    

        
          @tkh44