Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] - Site Redesign #1201

Merged
merged 25 commits into from
Feb 14, 2019
Merged

[WIP] - Site Redesign #1201

merged 25 commits into from
Feb 14, 2019

Conversation

tkh44
Copy link
Member

@tkh44 tkh44 commented Jan 31, 2019

My attempt at reworking the design of the site.

What:
image

@tkh44 tkh44 changed the title Site Redesign [WIP] - Site Redesign Jan 31, 2019
@emmatown
Copy link
Member

emmatown commented Feb 3, 2019

Some feedback:

  • link styles
    • the color they change to on hover is so similar to the default color that it's barely noticeable
    • the link color isn't applied to inline code
    • not totally sure about this but maybe an underline on hover would be nice
  • i really like the sidebar styling though maybe it could be sticky when you're scrolling and this i'm not super sure about but maybe the active link could be bold
  • the anchors on headings that appear on hover are strangely aligned, it should probably be vertically centered or something
  • community page is broken
  • there are three different background colors that are slightly different dark shades: search, code and live code
  • i really like the inline code styles
  • this is something that has been there for a while but when selecting code, the selection color is different depending on the token. Applying this css might work well
pre[class*="language-"]::selection, pre[class*="language-"] ::selection, .prism-code::selection, .prism-code ::selection {
    text-shadow: none;
    background: hsla(0,0%,100%,.15);
}
  • page titles being smaller than headings seems strange

@tkh44
Copy link
Member Author

tkh44 commented Feb 3, 2019

Thanks for the feedback. Here's the latest update.

@netlify
Copy link

netlify bot commented Feb 4, 2019

Preview Docs

Built with commit 43391a4

https://deploy-preview-1201--emotion.netlify.com

@emmatown
Copy link
Member

emmatown commented Feb 4, 2019

I'm not totally sure about the lack of separation between the different sections on the page. It feels harder to focus on the content because there's no separation between content and navigation

I really like the links at the top with the color change on hover and the underline.

I really liked when the pink indicator thing on the left of the nav links was right on the edge of the page.

@emmatown emmatown merged commit 0862810 into master Feb 14, 2019
@emmatown emmatown deleted the site-redesign branch February 14, 2019 06:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants