Add dev hint about css object (generated by Babel) being stringified by accident #1569
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset is good to goLatest commit: 32fa5ac We got this. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Andarist
force-pushed
the
dev-hint/stringified-css-obj-babel
branch
from
52a96cc to
c63c457
Compare
Codecov Report
|
emmatown
reviewed
Oct 25, 2019
| @@ -129,6 +136,7 @@ const SomeComponent = styled.div({ | |||
| ↓ ↓ ↓ ↓ ↓ ↓ | |||
|
|
|||
| import _styled from \\"@emotion/styled-base\\"; | |||
| var _EMOTION_STRINGIFIED_CSS_ERROR__ = \\"You have tried to stringify object returned from \`css\` function. It isn't supposed to be used directly (e.g. as value of the \`className\` prop), but rather handed to emotion so it can handle it (e.g. as value of \`css\` prop).\\"; | |||
There was a problem hiding this comment.
Yes, it should - stupid mistake 🤦♂ fixed!
Andarist
force-pushed
the
dev-hint/stringified-css-obj-babel
branch
from
c63c457 to
7a6a458
Compare
Andarist
force-pushed
the
dev-hint/stringified-css-obj-babel
branch
from
7a6a458 to
32fa5ac
Compare
emmatown
reviewed
Oct 25, 2019
| t.returnStatement(t.stringLiteral(CSS_OBJECT_STRINGIFIED_ERROR)) | ||
| ]) | ||
| ) | ||
| cssObjectToString._compact = true |
There was a problem hiding this comment.
A hint for babel generator, in this case it doesnt matter much - can remove it if you prefer to omit this.
It basically tells generator to print the statement in a single line, so instead of
function a() {
return 42
}it prints
function a() { return 42 }Babel is using this flag when inserting helpers.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Followup to #1219 . I haven't noticed before that Babel can generate this object too, so it bypasses the runtime serialization and thus it doesn't have this warning attached to it.