Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add @emotion/core/macro, remove @emotion/css #1630

Merged
merged 3 commits into from
Nov 15, 2019
Merged

Add @emotion/core/macro, remove @emotion/css #1630

merged 3 commits into from
Nov 15, 2019

Conversation

Andarist
Copy link
Member

No description provided.

@Andarist Andarist added the WIP label Nov 13, 2019
@changeset-bot
Copy link

changeset-bot bot commented Nov 13, 2019

🦋 Changeset is good to go

Latest commit: 746a850

We got this.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@codesandbox-ci
Copy link

codesandbox-ci bot commented Nov 13, 2019

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 746a850:

Sandbox Source
Emotion Configuration

@codecov
Copy link

codecov bot commented Nov 13, 2019

Codecov Report

Merging #1630 into next will increase coverage by <.01%.
The diff coverage is 100%.

Impacted Files Coverage Δ
packages/core/src/keyframes.js 100% <ø> (ø) ⬆️
packages/babel-plugin-emotion/src/core-macro.js 100% <ø> (ø)
packages/core/src/jsx.js 100% <ø> (ø) ⬆️
packages/babel-plugin-emotion/src/styled-macro.js 100% <100%> (ø) ⬆️
packages/core/macro.js 100% <100%> (ø)
...abel-plugin-emotion/src/utils/transformer-macro.js 100% <100%> (ø) ⬆️
...kages/babel-plugin-emotion/src/utils/add-import.js 100% <100%> (ø) ⬆️
packages/babel-plugin-emotion/src/index.js 93.97% <100%> (-0.47%) ⬇️
packages/core/src/css.js 100% <100%> (ø)
packages/babel-plugin-emotion/src/emotion-macro.js 92.3% <100%> (-0.29%) ⬇️
... and 4 more

@Andarist
Copy link
Member Author

@mitchellhamilton besides changesets - this is pretty much ready to be reviewed.

docs/babel-macros.mdx Outdated Show resolved Hide resolved
packages/babel-plugin-emotion/README.md Outdated Show resolved Hide resolved
packages/babel-plugin-emotion/README.md Outdated Show resolved Hide resolved
packages/css/src/index.js Outdated Show resolved Hide resolved
@Andarist
Copy link
Member Author

@mitchellhamilton I've applied suggested changes - anything else to do here besides adding changesets?

@emmatown
Copy link
Member

I think changesets is the only thing

@Andarist Andarist merged commit 843bfb1 into next Nov 15, 2019
@Andarist Andarist deleted the core-macro branch November 15, 2019 15:04
@Andarist Andarist removed the WIP label Nov 15, 2019
louisgv pushed a commit to louisgv/emotion that referenced this pull request Sep 6, 2020
* Add @emotion/core/macro, remove @emotion/css

* Apply suggestions from code review

Co-Authored-By: Mitchell Hamilton <[email protected]>

* Add changesets
@github-actions github-actions bot mentioned this pull request Nov 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants