Handle Global with Babel
#1639
Handle Global with Babel
#1639
Conversation
🦋 Changeset is good to goLatest commit: bf86d7d We got this. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 831d1d4:
|
packages/babel-plugin-emotion/__tests__/import-mapping/__snapshots__/import-mapping.js.snap
Outdated
Show resolved
Hide resolved
| sourceMap | ||
| }) | ||
|
|
||
| const { importSource = '@emotion/core', cssExport = 'css' } = state |
There was a problem hiding this comment.
seems like those should be configurable for import mapping case, any proposals for the API?
There was a problem hiding this comment.
Require that modules that export Global also export css, this is already done for jsx.
Andarist
force-pushed
the
global-macro
branch
from
78de88d to
fcb041e
Compare
Codecov Report
|
Andarist
force-pushed
the
global-macro
branch
4 times, most recently
from
c6fc774 to
687e9d8
Compare
Andarist
force-pushed
the
global-macro
branch
from
687e9d8 to
b5b0df5
Compare
|
@mitchellhamilton I've made changes around importMap and consider this to be done, please review 😄 |
.changeset/moody-stingrays-sort.md
Outdated
| '@emotion/core': minor | ||
| --- | ||
|
|
||
| `Global` gets handled by the Babel plugin now - this gives inline css-less expressions source maps. The same transforms are being applied for `Global` imported from macro entry (`@emotion/core/macro`).` |
There was a problem hiding this comment.
Could you split this changeset into two, one for the babel plugin and one for core?
* Handle `Global` with Babel * Fix support for Global transformer with importMap * Split changesets
closes #1474