Add a dev-only warning about opaque styles being passed to cx
#1810
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset is good to goLatest commit: 1a8536e We got this. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Andarist
force-pushed
the
warn-about-opaque-styles-passed-to-cx
branch
from
9c84ce1 to
ee2c9fd
Compare
Codecov Report
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 1a8536e:
|
emmatown
reviewed
Mar 16, 2020
packages/react/src/class-names.js
Outdated
| @@ -30,6 +30,15 @@ let classnames = (args: Array<ClassNameArg>): string => { | |||
| if (Array.isArray(arg)) { | |||
| toAdd = classnames(arg) | |||
| } else { | |||
| if ( | |||
| process.env.NODE_ENV !== 'production' && | |||
| arg.styles !== undefined | |||
There was a problem hiding this comment.
Could we check name as well just in case someone has a class name called styles?
emmatown
approved these changes
Mar 16, 2020
Andarist
force-pushed
the
warn-about-opaque-styles-passed-to-cx
branch
from
ee2c9fd to
1a8536e
Compare
louisgv
pushed a commit
to louisgv/emotion
that referenced
this pull request
Sep 6, 2020
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #1802