Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adds translate to the list of valid props #1971

Merged
merged 2 commits into from
Oct 11, 2020
Merged

adds translate to the list of valid props #1971

merged 2 commits into from
Oct 11, 2020

Conversation

mjcampagna
Copy link
Contributor

What:

Adds translate to the list of valid props.

Why:

Because it's a valid HTML attribute:
https://github.com/DefinitelyTyped/DefinitelyTyped/blob/master/types/react/index.d.ts#L1759

... and we'd like to be able to use it.

How:

Just added it to the list. Pretty straight-forward.

Checklist:

  • Documentation N/A
  • Tests
  • Code complete
  • Changeset N/A

@changeset-bot
Copy link

changeset-bot bot commented Aug 13, 2020

🦋 Changeset detected

Latest commit: c45887d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@emotion/is-prop-valid Minor
@emotion/primitives Patch
@emotion/styled-base Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@codecov
Copy link

codecov bot commented Aug 13, 2020

Codecov Report

❗ No coverage uploaded for pull request base (next@a836d31). Click here to learn what that means.
The diff coverage is n/a.

Impacted Files Coverage Δ
...ages/eslint-plugin-emotion/src/rules/no-vanilla.js 100.00% <0.00%> (ø)
packages/core/src/utils.js 100.00% <0.00%> (ø)
packages/babel-plugin-emotion/src/styled-macro.js 100.00% <0.00%> (ø)
scripts/test-utils/src/index.js 84.61% <0.00%> (ø)
packages/babel-plugin-jsx-pragmatic/src/index.js 94.11% <0.00%> (ø)
packages/hash/src/index.js 100.00% <0.00%> (ø)
...s/eslint-plugin-emotion/src/rules/styled-import.js 100.00% <0.00%> (ø)
packages/core/src/jsx.js 100.00% <0.00%> (ø)
packages/create-emotion-server/src/inline.js 100.00% <0.00%> (ø)
scripts/babel-tester/src/index.js 85.71% <0.00%> (ø)
... and 71 more

@Andarist
Copy link
Member

Whitelisting properties strikes again. It seems that it's a recommendation to support this as per HTML 5.1 which has been released in 2016. What's your opinion about this - is it OK to add this to a whitelist of the current major version of Emotion & Styled-Components? cc @mitchellhamilton @probablyup

@Andarist
Copy link
Member

Andarist commented Sep 5, 2020

@mitchellhamilton @probablyup 🏓

@Andarist Andarist changed the base branch from master to next October 11, 2020 11:25
@Andarist Andarist merged commit 69446cb into emotion-js:next Oct 11, 2020
@Andarist
Copy link
Member

@mjcampagna thanks!

@github-actions github-actions bot mentioned this pull request Oct 11, 2020
@github-actions github-actions bot mentioned this pull request Nov 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants