Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: do not escape strings in snapshots #2733

Merged
merged 4 commits into from
Apr 25, 2022

Conversation

SimenB
Copy link
Contributor

@SimenB SimenB commented Apr 24, 2022

What:

I noticed while going through some of your snapshots that they're harder to read than they need to be. Turning off string escaping (which will probably be the default in a future Jest major version) makes it easier

Why:

Easier to read snapshots makes them easier to maintain

How:

Added jest config and ran yarn jest -u. I had to manually mess around in packages/styled/__tests__/warnings.js and packages/css/test/no-babel/warnings.test.js due to some weird syntax errors (either with flow annotations or jsx) - not sure why.

Checklist:

  • Documentation
  • Tests
  • Code complete
  • Changeset

@changeset-bot
Copy link

changeset-bot bot commented Apr 24, 2022

⚠️ No Changeset found

Latest commit: 20f8d51

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@codesandbox-ci
Copy link

codesandbox-ci bot commented Apr 24, 2022

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 20f8d51:

Sandbox Source
Emotion Configuration

jest.config.js Outdated Show resolved Hide resolved
SimenB and others added 3 commits April 24, 2022 21:04
@Andarist Andarist merged commit ba5f146 into emotion-js:main Apr 25, 2022
@SimenB SimenB deleted the snapshot-escape-string branch April 25, 2022 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants