chore: do not escape strings in snapshots #2733
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
I noticed while going through some of your snapshots that they're harder to read than they need to be. Turning off string escaping (which will probably be the default in a future Jest major version) makes it easier
Why:
Easier to read snapshots makes them easier to maintain
How:
Added jest config and ran
yarn jest -u
. I had to manually mess around inpackages/styled/__tests__/warnings.js
andpackages/css/test/no-babel/warnings.test.js
due to some weird syntax errors (either with flow annotations or jsx) - not sure why.Checklist: