Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Media query nested selector fix #317

Merged
merged 3 commits into from
Sep 21, 2017
Merged

Conversation

emmatown
Copy link
Member

What:
Fix nested selectors in media queries

Why:
Closes #315

How:

Checklist:

  • Documentation N/A
  • Tests
  • Code complete

@codecov
Copy link

codecov bot commented Sep 21, 2017

Codecov Report

Merging #317 into master will increase coverage by 0.03%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #317      +/-   ##
==========================================
+ Coverage   96.25%   96.29%   +0.03%     
==========================================
  Files          16       16              
  Lines         561      567       +6     
  Branches      137      138       +1     
==========================================
+ Hits          540      546       +6     
  Misses         16       16              
  Partials        5        5
Impacted Files Coverage Δ
packages/emotion/src/index.js 99.08% <100%> (+0.05%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 39cd424...98c2e80. Read the comment docs.

@emmatown emmatown requested a review from tkh44 September 21, 2017 01:43
Copy link
Member

@tkh44 tkh44 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Little iffy on the global rule, but otherwise lgtm.

@tkh44 tkh44 merged commit 30d8321 into master Sep 21, 2017
@tkh44 tkh44 deleted the media-query-nested-selector-fix branch September 21, 2017 02:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Media query styles always applied to nested selectors @8.0.2-0
2 participants