Insertion plugin with tree #386
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 7 commits
October 5, 2017 09:22
Codecov Report
|
emmatown
reviewed
Oct 6, 2017
packages/emotion/src/index.js
Outdated
| } | ||
|
|
||
| function Node(id, selector, parent, ruleText) { | ||
| this.id = id |
There was a problem hiding this comment.
No, they were but not anymore.
emmatown
approved these changes
Oct 6, 2017
|
@tkh44 The current AST plugin in the stylis repo could benefit from a lot of optimizations and improvements. For example this gist demos one that preserves nested children within the AST. Did you find any pain points that could be used to improve the stylis plugin system? I'm thinking of passing a depth argument to have data about what depth a rule in a nested selector is in. |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
Stylis processes styles from the inside out so we need to build some kind of structure to ensure proper insertion order of the rules.
See #384 for more details.
Why:
Nested pseudo selectors were breaking.
How:
Simple tree structure is used. The idea came from the stylis AST plugin.
Checklist:
closes #384