Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incorrect usage of css variable in docs #423

Merged
merged 1 commit into from
Oct 20, 2017

Conversation

ekeric13
Copy link
Contributor

@ekeric13 ekeric13 commented Oct 20, 2017

The way the css variables is being used in that example is incorrect, it is missing a var().
https://developer.mozilla.org/en-US/docs/Web/CSS/Using_CSS_variables

What: Quick typo fix in the extract static docs.

Why: Adds clarification and stops misinformation on css variables to other devs.

Checklist:

  • Documentation
  • Tests N/A
  • Code complete N/A

The way the css variables is being used in that example is incorrect, it is missing a `var()`.
https://developer.mozilla.org/en-US/docs/Web/CSS/Using_CSS_variables
Copy link
Member

@emmatown emmatown left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@emmatown emmatown merged commit 8f2ce83 into emotion-js:master Oct 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants