Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update rollup #457

Merged
merged 1 commit into from
Nov 10, 2017
Merged

Update rollup #457

merged 1 commit into from
Nov 10, 2017

Conversation

emmatown
Copy link
Member

What:

Update Rollup.

Why:

Previously, in the esm bundle, rollup generated an import for emotion like this.

import * as emotion from 'emotion'

This can't work with tree shaking since every export of emotion is used. (even though tree shaking won't do very much for the emotion package since most of the code is used by all the exports, this is mainly to make tree shaking work(hopefully) for #453 since tree-shaking will actually help that)
Now, rollup generates an import like this

import { css, getRegisteredStyles } from 'emotion'

so it should work better with tree shaking.

How:

yarn upgrade-interactive --latest

Checklist:

  • Documentation N/A
  • Tests N/A
  • Code complete

There is a small size increase to the UMD build but it's to the way the UMD is defined and checking for a default import, so it won't affect the way the majority of consumers will use it, with ESM.

Copy link
Member

@tkh44 tkh44 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tkh44 tkh44 merged commit 39e9a98 into master Nov 10, 2017
@tkh44 tkh44 deleted the update-rollup branch November 10, 2017 22:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants