Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
Update Rollup.
Why:
Previously, in the esm bundle, rollup generated an import for emotion like this.
This can't work with tree shaking since every export of emotion is used. (even though tree shaking won't do very much for the
emotion
package since most of the code is used by all the exports, this is mainly to make tree shaking work(hopefully) for #453 since tree-shaking will actually help that)Now, rollup generates an import like this
so it should work better with tree shaking.
How:
yarn upgrade-interactive --latest
Checklist:
There is a small size increase to the UMD build but it's to the way the UMD is defined and checking for a default import, so it won't affect the way the majority of consumers will use it, with ESM.