[babel-plugin-emotion][react-emotion] Adds Support for Components as Selectors Using the Object Syntax #501 #503
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Selectors Using the Object Syntax #501
emmatown
approved these changes
Dec 23, 2017
emmatown
reviewed
Dec 23, 2017
packages/react-emotion/src/index.js
Outdated
| process.env.NODE_ENV !== 'production' && | ||
| stableClassName === undefined | ||
| ) { | ||
| throw new Error('') |
There was a problem hiding this comment.
Could you add make this error be 'Component selectors can only be used in conjunction with babel-plugin-emotion.'
|
@mitchellhamilton Absolutely! I will add the documentation right away. It looks like CI is failing because of the size? Is this going to be an issue? |
|
@smlmrkhlms In the root package.json, in the bundlesize section, increase the react-emotion limit to 9.1kb |
added 2 commits
December 22, 2017 17:58
Codecov Report
|
|
Could you add a test here to with something like this expect(() => {
// try to use a component selector with the object syntax
}).toThrowErrorMatchingSnapshot() |
emmatown
approved these changes
Dec 23, 2017
|
@mitchellhamilton Thanks for your help and guidance! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #501
What: Adding the ability to use components as selectors when object syntax is being used.
Why: To achieve api parity regardless of the syntax being used.
How: Under direction of @mitchellhamilton via comments on issue #501.
Checklist: