Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use @emotion/memoize #620

Merged
merged 1 commit into from
Apr 7, 2018
Merged

Use @emotion/memoize #620

merged 1 commit into from
Apr 7, 2018

Conversation

Andarist
Copy link
Member

@Andarist Andarist commented Apr 7, 2018

Checklist:

  • Documentation
  • Tests
  • Code complete

@emmatown
Copy link
Member

emmatown commented Apr 7, 2018

Oops, I forgot to run build so the @emotion/memoize doesn't have the dist files, also @emotion/memoize needs to be added here.

@emmatown
Copy link
Member

emmatown commented Apr 7, 2018

Fixed version published. @emotion/[email protected]

@Andarist
Copy link
Member Author

Andarist commented Apr 7, 2018

Fixed my PR

emmatown
emmatown reviewed Apr 7, 2018
View reviewed changes
rollup.config.js Outdated
external: baseExternal.concat(
uniq(
flatMap(
dir => Object.keys(require(`${dir}/package.json`).dependencies || {}),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should include peerDependencies too.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch, fixed

@codecov
Copy link

codecov bot commented Apr 7, 2018 •
edited
Loading

Codecov Report

Merging #620 into master will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted Files Coverage Δ
packages/emotion-utils/src/index.js 100% <ø> (ø) ⬆️
packages/create-emotion-styled/src/utils.js 100% <100%> (ø) ⬆️

emmatown
emmatown approved these changes Apr 7, 2018
View reviewed changes
Copy link
Member

@emmatown emmatown left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!!

@emmatown emmatown merged commit c26af0d into emotion-js:master Apr 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emmatown emmatown emmatown approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Andarist @emmatown