Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add typings for preact-emotion #680

Merged
merged 5 commits into from
Jun 5, 2018
Merged

Add typings for preact-emotion #680

merged 5 commits into from
Jun 5, 2018

Conversation

Ailrun
Copy link
Member

@Ailrun Ailrun commented May 26, 2018 •
edited
Loading

What: preact-emotion typing

Why: For TS user to be able to use preact-emotion

How: Copy-and-paste react-emotion typing and fix broken things

Checklist:

  • [N/A] Documentation
  • Tests
  • Code complete

@Ailrun Ailrun mentioned this pull request May 26, 2018
Merged
1 task
@Ailrun Ailrun force-pushed the typing/preact-emotion branch 2 times, most recently from 63c8c7b to 4ea2621 Compare May 26, 2018 08:13
@Ailrun Ailrun force-pushed the typing/preact-emotion branch from 92b5b6c to b366735 Compare May 27, 2018 01:08
@Ailrun
Copy link
Member Author

Ailrun commented May 27, 2018

@mitchellhamilton I rebased this PR. Could you please check this?

@emmatown
Remove alias
9206c3b 
since preact-emotion doesn't have typings right now, there won't be anyone using it so there's no need to have the alias
@Ailrun
Copy link
Member Author

Ailrun commented Jun 5, 2018

@mitchellhamilton Sorry for bothering you. Is there any progress?

emmatown
emmatown approved these changes Jun 5, 2018
View reviewed changes
Copy link
Member

@emmatown emmatown left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!!

@emmatown emmatown merged commit f2893be into emotion-js:master Jun 5, 2018
@rand0me rand0me mentioned this pull request Jun 5, 2018
Closed
@rand0me
Copy link

rand0me commented Jun 5, 2018

Big thanks to @Ailrun
Guys, can you close #610 when this will be released?

emmatown pushed a commit that referenced this pull request Jun 7, 2018
@Ailrun @emmatown
Update typescript document to match with current types (#679)
12281c1 
**What**: Update typescript document

**Why**: Typings are changed, so document is outdated.

<!-- Have you done all of these things?  -->
**Checklist**:
- [x] Documentation
- [N/A] Tests
- [N/A] Code complete

This document depends on #678 and #680, so please do not merge this before them.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emmatown emmatown emmatown approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Ailrun @rand0me @emmatown @tkh44