Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add third party packages section to document #715

Closed
wants to merge 3 commits into from

Conversation

Ailrun
Copy link
Member

@Ailrun Ailrun commented Jun 11, 2018

What: Documents for third party packages

Why: To support and encourage third party package authors.

How: Rename "Packages" section into "Official Packages" and add "Third Party Packages" section.

Checklist:

  • Documentation
  • [N/A] Tests
  • [N/A] Code complete

Resolves #638.

@Ailrun Ailrun self-assigned this Jun 11, 2018
@Ailrun Ailrun mentioned this pull request Jun 11, 2018
@Ailrun
Copy link
Member Author

Ailrun commented Jun 11, 2018

What is that weird error? Why couldn't it find a handlebar?
@mitchellhamilton Do you know what the error means? Could you let me know?

@emmatown
Copy link
Member

@Ailrun It's saying that the language handlebars hasn't been imported.
Add this here

require('prismjs/components/prism-handlebars')

@Ailrun
Copy link
Member Author

Ailrun commented Jun 12, 2018

@mitchellhamilton Ah, his document use handlebars... I missed that part. I will fix that.

@Ailrun Ailrun force-pushed the docs/third-party branch from 0b5ba9b to a0f7210 Compare June 12, 2018 08:00
@emmatown
Copy link
Member

I've been thinking about this and I'm not sure if it's a good idea because if we add the documentation for one package then we have to add the documentation for every package that wants it and it's effectively saying we recommend whatever packages that are there.

I think a better solution is to add a top level Community page, add it to the links at the top and have the contents be from emotion-js/awesome-emotion which I just created, similar to https://www.styled-components.com/ecosystem.

@Ailrun
Copy link
Member Author

Ailrun commented Jun 12, 2018

@mitchellhamilton Wow, awesome opinion! Thank you for making that repository. However, I wish that there is a link to your repository from our site. Is it OK for you?

@emmatown
Copy link
Member

I was thinking, instead of linking to it, embed the contents of it in the site.

@Ailrun
Copy link
Member Author

Ailrun commented Jun 12, 2018

@mitchellhamilton All contents? Just like styled component did?

@Ailrun
Copy link
Member Author

Ailrun commented Jun 13, 2018

Close this in favor of #720.

@Ailrun Ailrun closed this Jun 13, 2018
@Ailrun Ailrun deleted the docs/third-party branch June 13, 2018 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants