fix extra 404 when visiting index pages #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
locks
approved these changes
Jan 28, 2020
|
I'm merging this even though Travis is failing because of emberjs/ember.js#18693 It's only failing on ember-beta so hopefully it will be fixed soon 🙈 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This has been a bit of a long-standing question: why do the index routes always have a 404 error on them?
It was initially for simplicity and we were depending on a "try files" style implementation to allow it to work but recently our hosting provider for the ember guides has changed something about 404 errors and they now time out after a few minutes instead of returning quickly.
This is the first step to fix that.
I mention in the comment that it's not a perfect solution but it does work and will fix the majority of issues on the majority of pages 👍