Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

walk the tree of pages to find an index #39

Merged
merged 3 commits into from
Mar 10, 2020
Merged

walk the tree of pages to find an index #39

merged 3 commits into from
Mar 10, 2020

Conversation

mansona
Copy link
Member

@mansona mansona commented Feb 17, 2020

This is needed because we currently have the ability to have arbitrary nesting of routes. I am personally not a fan of making this so complex but with the current feature set it's necessary 😞

@jenweber
Copy link
Contributor

I think using recursion makes sense here, and your code comments make it easy to follow.

Failing tests are for beta and canary of Ember, for a method you aren't using directly anywhere in this repo. I wonder if perhaps this should be merged after setting beta to be allowed to fail, and then we fix that separately.

@mansona
Copy link
Member Author

mansona commented Feb 28, 2020

@jenweber so sorry, I forgot to mention that beta and canary were failing because of emberjs/ember.js#18693 which is now fixed. I re-pushed my change to kick off CI again and it should be ready to merge 👍

@mansona
Copy link
Member Author

mansona commented Feb 28, 2020

@jenweber it looks like I spoke too soon 🤔 It looks like CI isn't failing because of the known bug I was linking to, but instead it's failing because of a different regression in Ember 🙈 I will try to investigate a little bit if I can

@mansona
Copy link
Member Author

mansona commented Mar 2, 2020

@jenweber I ended up fixing CI by updating ember because there were a few strange things going on with older ember-try scenarios.

If you're still ok with this can you review and merge? thanks 🎉

Copy link
Contributor

@jenweber jenweber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thank you Chris!

@jenweber jenweber merged commit 4d1056d into master Mar 10, 2020
@delete-merged-branch delete-merged-branch bot deleted the nested-indexes branch March 10, 2020 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants