Removed included() method, which only added ember-prism options.
#93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…we count on ember-showdown-prism to do that.
✅ Deploy Preview for guidemaker ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
mansona
approved these changes
Sep 30, 2023
There was a problem hiding this comment.
I'm surprised this code was even in here 🙈 this has essentially been a bug for quite a while now. This should technically be a breaking change but guidemaker (this repo) was never supposed to be in charge of the visual aspects of the process, instead that was delegated to the templates. I'm going to consider this a bugfix 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now we count on
ember-showdown-prismto do that, and having a set of options applied in here prevents them from being applied in there. This branch passes tests and runs locally, so I don't think I broke anything.Full disclosure: This project, built on Ember 3.28, has no ember-try cases for Ember 4, and all the release, beta, canary cases for Ember 5 fail because of references to
@ember/debug, which no longer exists, inember-data3.28, which this project uses. I temporarily added cases for Ember 4.8 and 4.12 and they both passed ember-try. None of this behavior differed in this branch from the behavior in main, so it is all an existing condition.