fix(run): update aws-cdk #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zmstone
approved these changes
Nov 26, 2021
This updates the base image and the python lib versions. I needed to do this because I encountered this bug in aws-cdk: aws/aws-cdk#14738 Just doing the workaround inside a Dockerfile based on `contino/aws-cdk` did not work for me. But rebuilding the image itself did. Related PR: contino/docker-aws-cdk#6 **Don't merge before the above PR is merged and the new image released**
thalesmg
force-pushed
the
fix-run-script
branch
from
2fd9451 to
0f90248
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the base image and the python lib versions.
I needed to do this because I encountered this bug in aws-cdk:
aws/aws-cdk#14738
Just doing the workaround inside a Dockerfile based on
contino/aws-cdkdid not work for me. But rebuilding the imageitself did.
Related PR: contino/docker-aws-cdk#6Don't merge before the above PR is merged and the new image releasedNow that we are using our own fork and image registry, the new image is available for everyone.