-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: install zsh on unbuntu for developing #111
Conversation
@zhongwencool missing |
But if you install zsh package, may be you don't need that script in the Dockerfile? |
51060af
to
260e735
Compare
The current bash is too basic, it's inconvenient to develop within it |
What I meant is since you install |
To summarize my comments: I don't think you need to change any distro-specific Dockerfiles. |
63a62d5
to
bab6d94
Compare
bab6d94
to
a73935d
Compare
I've noticed that that repo is rarely updated. Maybe we can just copy that script directly into get-zsh.sh and maintain it ourselves? |
I'm testing this now #112. |
40529d2
to
c911cdb
Compare
alternatives --list | grep python && alternatives --set python /usr/bin/python3 || true | ||
|
||
## cleanup | ||
cd / |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cd / | |
cd .. |
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pretty much the same in this case
No description provided.