Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Emscripting Python with optimizations+assertions produces invalid code #28

Closed
max99x opened this issue Jun 24, 2011 · 1 comment
Closed

Comments

@max99x
Copy link
Contributor

max99x commented Jun 24, 2011

Running emscripten on python.ll with OPTIMIZE = 1, RELOOP=1 and ASSERTIONS=1 produces many invalid blocks, of the general form:

if ($n) {
  ...
}
else {
  ...
}
else { throw "Bad multiple branching: " + __label__ + " : " + (new Error().stack); }

The extra else is added at jsifier.js:402. Removing these lines from the result produces a working file (which is about 10 times faster than the unoptimized version).

@kripken
Copy link
Member

kripken commented Jun 25, 2011

Thanks! That was an old assertion that is no longer needed. The bug only happened with that combination of those flags, which we don't test (too many combinations to check everything...).

Fixed in 009dc48

@kripken kripken closed this as completed Jun 25, 2011
tlively pushed a commit to tlively/emscripten that referenced this issue Mar 23, 2022

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
Add support for 'mode' parameter in createSyncAccessHandle
steveisok pushed a commit to steveisok/emscripten that referenced this issue Sep 18, 2023

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
…913.1 (emscripten-core#28)

[dotnet/release/8.0] Update dependencies from dotnet/arcade
eagleoflqj pushed a commit to eagleoflqj/emscripten that referenced this issue Nov 16, 2024
Add fcitx4's show input method status when focus in.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants