Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The pthread stub is missing almost all pthread_rwlock_* functions #4130

Closed
tomaka opened this issue Feb 28, 2016 · 2 comments
Closed

The pthread stub is missing almost all pthread_rwlock_* functions #4130

tomaka opened this issue Feb 28, 2016 · 2 comments
Labels
multithreading

Comments

@tomaka
Copy link
Contributor

tomaka commented Feb 28, 2016

I wanted to submit a PR for this but I don't really have time anymore.

It would be nice if the pthread_rwlock functions were implemented in library_pthread_stub.js (like mutexes are) so that code that uses rw locks can be used in a single-threaded context.
@tomaka tomaka mentioned this issue Feb 28, 2016
Closed
juj added a commit that referenced this issue Feb 29, 2016
@juj
Add no-op stubs of pthread condattr, rwlock, rwlockattr and spin func…
1c5cf47 
…tions when building with pthreads disabled. Closes #4130.
@juj
Copy link
Collaborator

juj commented Feb 29, 2016

Added in above commit.

@juj juj closed this as completed Feb 29, 2016
@tomaka
Copy link
Contributor Author

tomaka commented Feb 29, 2016

Nice, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
multithreading
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@juj @tomaka