Improve embind when using c++17. #10613
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In C++17, the `noexcept` qualifier became part of the function signature, so we must match it along with const / non-const.
|
@chadaustin You might find this interesting! |
|
😮 Seems reasonable to me, but is it possible to have the noexcept specialization defer to the non-noexcept specialization? |
|
Any further thoughts on this? I'd really like to see this land before the next emscipten release so that I can update to it more readily... |
|
Looks like @chadaustin had a question? Also maybe @jgravelle-google will have thoughts. |
| ReturnType (ClassType::*memberFunction)(Args...) const) { | ||
| auto invoker = &MethodInvoker<decltype(memberFunction), ReturnType, const ClassType*, Args...>::invoke; | ||
|
|
||
| typename WithPolicies<Policies...>::template ArgTypeList<ReturnType, AllowedRawPointer<const ClassType>, Args...> args; |
There was a problem hiding this comment.
Is this the only line of difference between the bodies of these two methods? That's really hard to spot in the middle of the rest of this duplicated code. Any way to compress these into one body?
Basically what @chadaustin said, yeah.
|
This issue has been automatically marked as stale because there has been no activity in the past year. It will be closed automatically if no further activity occurs in the next 30 days. Feel free to re-open at any time if this issue is still relevant. |
brendandahl
added a commit
to brendandahl/emscripten
that referenced
this pull request
Jun 2, 2022
This continues the work from emscripten-core#15273 and emscripten-core#10613 which supports the noexcept keyword by ignoring it on c++17 compilers. I've also added a missing template for class methods and tests for each possible use of noexcept.
brendandahl
added a commit
to brendandahl/emscripten
that referenced
this pull request
Jun 3, 2022
This continues the work from emscripten-core#15273 and emscripten-core#10613 which supports the noexcept keyword by ignoring it on c++17 compilers. I've also added a missing template for class methods and tests for each possible use of noexcept.
brendandahl
added a commit
to brendandahl/emscripten
that referenced
this pull request
Jun 7, 2022
This continues the work from emscripten-core#15273 and emscripten-core#10613 which supports the noexcept keyword by ignoring it on c++17 compilers. I've also added a missing template for class methods and tests for each possible use of noexcept.
brendandahl
added a commit
to brendandahl/emscripten
that referenced
this pull request
Jun 9, 2022
This continues the work from emscripten-core#15273 and emscripten-core#10613 which supports the noexcept keyword by ignoring it on c++17 compilers. I've also added a missing template for class methods and tests for each possible use of noexcept.
brendandahl
added a commit
to brendandahl/emscripten
that referenced
this pull request
Jun 9, 2022
This continues the work from emscripten-core#15273 and emscripten-core#10613 which supports the noexcept keyword by ignoring it on c++17 compilers. I've also added a missing template for class methods and tests for each possible use of noexcept.
brendandahl
added a commit
that referenced
this pull request
Jun 10, 2022
* Add support for noexcept keyword in C++ class methods * Remove code duplication after adding support for noexcept * Add support for noexcept keyword to embind. This continues the work from #15273 and #10613 which supports the noexcept keyword by ignoring it on c++17 compilers. I've also added a missing template for class methods and tests for each possible use of noexcept. Co-authored-by: Hunter Richards <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In C++17, the
noexceptqualifier became part of the functionsignature, so we must match it along with const / non-const.