Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explicitly use utf-8 in create_file during tests #17211

Merged
merged 1 commit into from
Jun 14, 2022
Merged

Conversation

tlively
Copy link
Member

@tlively tlively commented Jun 14, 2022

This may help solve the current breakage on the Windows roller, which appears to
be defaulting to the "charmap" codec that cannot encode a character used in the
other.test_prejs_unicode test.

This may help solve the current breakage on the Windows roller, which appears to
be defaulting to the "charmap" codec that cannot encode a character used in the
other.test_prejs_unicode test.
@tlively tlively requested review from kripken and sbc100 June 14, 2022 02:18
@tlively
Copy link
Member Author

tlively commented Jun 14, 2022

Current dependencies on/for this PR:

This comment was auto-generated by Graphite.

@tlively
Copy link
Member Author

tlively commented Jun 14, 2022

Copy link
Collaborator

@sbc100 sbc100 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder why this didn't happen consistently.

@sbc100 sbc100 merged commit af3d98b into main Jun 14, 2022
@sbc100 sbc100 deleted the create-file-utf-8 branch June 14, 2022 15:19
@sbc100
Copy link
Collaborator

sbc100 commented Jun 14, 2022

Ah.. I see what happened.

We were setting PYTHONUTF8 on the emscripten-releases waterfall. The plan was to remove it but it is still there currently:
https://chromium-review.googlesource.com/c/emscripten-releases/+/3684010

Then #16736 landed which made emscripten stop honoring this environment variable (and others).

So this PR then became needed .. which is the correct fix.

The failure of test_prejs_unicode didn't show up in github CI because its windows-only and we only run a specific subset of tests here (it should really be one of them).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants