Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

library_webgpu: remove assertion that is wrong for OffscreenCanvas #17889

Merged
merged 1 commit into from
Sep 19, 2022
Merged

library_webgpu: remove assertion that is wrong for OffscreenCanvas #17889

merged 1 commit into from
Sep 19, 2022

Conversation

kainino0x
Copy link
Collaborator

No description provided.

@kainino0x kainino0x requested a review from sbc100 September 19, 2022 19:22
@kainino0x kainino0x enabled auto-merge (squash) September 19, 2022 19:22
@kainino0x kainino0x mentioned this pull request Sep 19, 2022
Closed
sbc100
sbc100 approved these changes Sep 19, 2022
View reviewed changes
Copy link
Collaborator

@sbc100 sbc100 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm with question

src/library_webgpu.js Show resolved Hide resolved
@kainino0x kainino0x merged commit 83234f2 into main Sep 19, 2022
@kainino0x kainino0x deleted the kainino0x-patch-1 branch September 19, 2022 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sbc100 sbc100 sbc100 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kainino0x @sbc100