Avoid unnecessary pointer params for gmtime/localtime. NFC #19698
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbc100
force-pushed
the
avoid_pointer_arg
branch
from
d700299 to
07992ad
Compare
sbc100
force-pushed
the
avoid_pointer_arg
branch
from
07992ad to
a31d107
Compare
kripken
approved these changes
Jun 23, 2023
sbc100
force-pushed
the
avoid_pointer_arg
branch
from
a31d107 to
98e3466
Compare
Seems like there is no reason to pass a pointer here. I noticed this while investigating #19694.
sbc100
force-pushed
the
avoid_pointer_arg
branch
from
98e3466 to
f01e545
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Seems like there is no reason to pass a pointer here.
I noticed this while investigating #19694.