Use exported memory when building a MAIN_MODULE. NFC #22332
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Side modules import the memory but the main module should export it.
|
Marking as draft since I think this might be more complex that i thought. I'm think as long as we are buiding the main module as PIC the linker cannot create the memory since it doesn't know how much space it needs to use. |
kripken
reviewed
Aug 7, 2024
| @@ -315,8 +312,6 @@ var LibraryDylink = { | |||
| } else if (typeof value == 'bigint') { | |||
| entry.value = value; | |||
| #endif | |||
| } else { | |||
| throw new Error(`bad export type for '${symName}': ${typeof value}`); | |||
There was a problem hiding this comment.
I am guessing these changes are to do with handling a Memory export. But I see only removals. Where is the code that handles it?
There was a problem hiding this comment.
This should should just ignore exports such as memories and tables. Its only interesting in handling globals and functions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Side modules import the memory but the main module should export it.