[EH] Rename Wasm EH tests #23427
Merged
[EH] Rename Wasm EH tests #23427
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This renames Wasm EH test modes: - `wasm` -> `wasm_legacy` - `wasm_exnref` -> `wasm` So `_wasm` suffix means the standardized Wasm EH, and `_wasm_legacy` means the legacy EH. This also removes some comments mentioning things like "new Wasm EH with exnref", given that this should be (eventually) the default mode and not the new thing.
sbc100
approved these changes
Jan 16, 2025
| @@ -15316,8 +15314,8 @@ def test_SUPPORT_BIG_ENDIAN(self): | |||
| 'noexcept': ['-fno-exceptions'], | |||
| 'default': [], | |||
| 'except': ['-sDISABLE_EXCEPTION_CATCHING=0'], | |||
| 'except_wasm': ['-fwasm-exceptions', '-sWASM_LEGACY_EXCEPTIONS'], | |||
| 'except_wasm_exnref': ['-fwasm-exceptions', '-sWASM_LEGACY_EXCEPTIONS=0'] | |||
| 'except_wasm': ['-fwasm-exceptions', '-sWASM_LEGACY_EXCEPTIONS=0'], | |||
There was a problem hiding this comment.
Can you just drop the '-sWASM_LEGACY_EXCEPTIONS=0' here maybe?
There was a problem hiding this comment.
This is meant to be Wasm (exnref) so without that it will use the legacy exception instead, no? (WASM_LEGACY_EXCEPTIONS is on by default now)
There was a problem hiding this comment.
Oh I didn't realize that part. lgtm
This is an automatic change generated by tools/maint/rebaseline_tests.py. The following (1) test expectation files were updated by running the tests with `--rebaseline`: ``` other/codesize/test_codesize_cxx_except_wasm.size: 142162 => 144708 [+2546 bytes / +1.79%] Average change: +1.79% (+1.79% - +1.79%) ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This renames Wasm EH test modes:
wasm->wasm_legacywasm_exnref->wasmSo
_wasmsuffix means the standardized Wasm EH, and_wasm_legacymeans the legacy EH. This also removes some comments mentioning things like "new Wasm EH with exnref", given that this should be (eventually) the default mode and not the new thing.