Various fixes to IO stubs #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ule.run * improved the behaviour of ungetc * added optional argument to intArrayFromString to not add the trailing NULL -- useful when adding JS strings as the data in the virtual file system
…fputs does not) * corrected internal filennames of stderr and stdout * added default getgid(void) implementation to go with getuid(void)
|
Hey, this looks good, thanks! I'll take a closer look later today. Meanwhile, can you please add yourself to AUTHORS (which I just pushed an update to)? That means you officially license your contributions under the project's licensing (MIT / LLVM license). |
|
Ok, this looks great. I have one minor style fix but I'll do it myself ( { } are used even in single-line ifs). We will need to run all the automatic tests for changes like this. I'm fairly certain they will pass though so I'll run them after I merge (they will take all night). Thanks again! |
tlively
pushed a commit
to tlively/emscripten
that referenced
this pull request
Mar 23, 2022
Add realpath support
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've been working with the IO stubs a lot over the past week and I have a number of fixes / improvements. There will be some more to come soon.