Remove -upstream component of SDK names
#1166
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbc100
force-pushed
the
remove_upstream
branch
2 times, most recently
from
dc82f07 to
fa3aa8f
Compare
|
Is this a breaking change? If so, can we strip |
Yes, the |
Because the old names are still supported I think this is a backwards compatible change. |
|
Sounds good. Not sure why the tests fail then, you are right that that line should be stripping the suffix. |
sbc100
force-pushed
the
remove_upstream
branch
from
fa3aa8f to
277a695
Compare
|
ping.. ok to land once tests pass? |
sbc100
force-pushed
the
remove_upstream
branch
from
277a695 to
30a8ca5
Compare
|
Lgtm, but please add a test (or keep one) that checks we strip |
This name existed to distinguish the SDK from fastcomp, but as of #1165, we no longer support fastcomp.
sbc100
force-pushed
the
remove_upstream
branch
from
30a8ca5 to
0288a20
Compare
sbc100
added a commit
that referenced
this pull request
Jan 14, 2023
The name `upstream` doesn't have any meaning anymore now that there is no more fastcomp. It was removed from the SDK names in #1166 and this is the last usage of that name/term.
sbc100
added a commit
that referenced
this pull request
Jan 14, 2023
The name `upstream` doesn't have any meaning anymore now that there is no more fastcomp. It was removed from the SDK names in #1166 and this is the last usage of that name/term.
sbc100
added a commit
that referenced
this pull request
Jan 14, 2023
The name `upstream` doesn't have any meaning anymore now that there is no more fastcomp. It was removed from the SDK names in #1166 and this is the last usage of that name/term.
sbc100
added a commit
that referenced
this pull request
Jan 14, 2023
The name `upstream` doesn't have any meaning anymore now that there is no more fastcomp. It was removed from the SDK names in #1166 and this is the last usage of that name/term.
sbc100
added a commit
that referenced
this pull request
Jan 14, 2023
sbc100
added a commit
that referenced
this pull request
Jan 17, 2023
shlomif
pushed a commit
to shlomif/emsdk
that referenced
this pull request
Sep 29, 2023
This name existed to distinguish the SDK from fastcomp, but as of emscripten-core#1165, we no longer support fastcomp.
shlomif
pushed a commit
to shlomif/emsdk
that referenced
this pull request
Sep 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This name existed to distinguish the SDK from fastcomp, but as of #1165, we no longer support fastcomp.