Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change list-of-POSIX-paths to list-of-strings in yield of iterate_pip_pkg_record() function #104

Merged
merged 1 commit into from
Sep 2, 2024

Conversation

michaelweinold
Copy link
Contributor

@DerThorsten DerThorsten added the bug Something isn't working label Aug 25, 2024
@DerThorsten
Copy link
Collaborator

lgtm, the failing test seems unrelated

@michaelweinold michaelweinold marked this pull request as ready for review August 25, 2024 15:38
@michaelweinold
Copy link
Contributor Author

Once this is merged and a bugfix-release published - is it sufficient to specify the version in the build-environment.yml?

I am a little confused because empack is being installed in the mamba environment where the packages from environment.yml are all added.

@michaelweinold
Copy link
Contributor Author

@DerThorsten, is there any way a bugfix release could be made before mid-September. We were hoping to switch from Pyodide to the more performant XEUS kernel - but this is currently blocking us 🙈

@DerThorsten
Copy link
Collaborator

@michaelweinold Sure, for releases, I usually summon @martinRenou :)

@martinRenou
Copy link
Contributor

The test failure boils down to this:

Traceback (most recent call last):  File "main.py", line 6, in <module>
    from scipy.linalg import lapack
  File "/lib/python3.11/site-packages/scipy/linalg/__init__.py", line 206, in <module>
    from ._misc import *
  File "/lib/python3.11/site-packages/scipy/linalg/_misc.py", line 3, in <module>
    from .blas import get_blas_funcs
  File "/lib/python3.11/site-packages/scipy/linalg/blas.py", line 213, in <module>
    from scipy.linalg import _fblas
AttributeError: _ARRAY_API not found
error while evaluating main file: {has_err: true, message: ImportError: numpy.core.multiarray failed to impor…ap>(1181): _find_and_load
  main.py(6): <module>
, error: ImportError: numpy.core.multiarray failed to impor…ap>(1181): _find_and_load
  main.py(6): <module>
}

Did we upload a new version of scipy/numpy recently?

@martinRenou
Copy link
Contributor

Definitely unrelated to this PR though

Copy link
Contributor

@martinRenou martinRenou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@martinRenou martinRenou merged commit e2e8819 into emscripten-forge:main Sep 2, 2024
3 of 5 checks passed
martinRenou added a commit that referenced this pull request Sep 5, 2024
martinRenou added a commit that referenced this pull request Sep 5, 2024
@martinRenou
Copy link
Contributor

I had to revert this PR as it seems it's breaking pip packages: #105

Will release a patch release right away

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants