Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Include/Exclude Patterns for pint Package to empack_config (#2) #97

Merged
merged 1 commit into from
May 21, 2024
Merged

Add Include/Exclude Patterns for pint Package to empack_config (#2) #97

merged 1 commit into from
May 21, 2024

Conversation

michaelweinold
Copy link
Contributor

This follows advice by @martinRenou provided in

jupyterlite/xeus-python-kernel#79 (comment)

and should close

jupyter-xeus/xeus-python#603

(and by extension)

brightway-lca/brightway-live#52

Note

This was first added to recipes/empack_config.yaml, which is a historical artefact according to the discussion here: emscripten-forge/recipes#1047 (comment)

@martinRenou
Copy link
Contributor

Thanks!

@michaelweinold
Copy link
Contributor Author

Do I understand correctly that the xeus kernel uses empack during the build of the JupyterLite site? I would therefore need to wait for the next release of empack and re-build my site - no further changes required?

@martinRenou martinRenou added the enhancement New feature or request label May 21, 2024
@martinRenou
Copy link
Contributor

You're absolutely right. I can make a patch release of empack with this.

@martinRenou martinRenou merged commit 7841187 into emscripten-forge:main May 21, 2024
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants