Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
C-Kernel
@JanThorbecke and I implemented a C-kernel, simply out of curiosity to compare to the existing Numba Kernel.
Benchmarking has shown that, in the case of empymod, the speed between Numba and C is very comparable. (Different runs will show slightly different results, don't over-interpret the figure.)
To make use of the C-kernel you have to download/clone the repo, checkout the branch
c-kernel
, and runmake install
in the root directory. If you then setht='cdlf'
(instead ofht='dlf'
), the C-kernel will be used.Please post question and feedback regarding the C-kernel in this PR.
There are still some edge-cases where the C-Kernel produces different results. To test and debug, run, e.g.:
pytest tests/test_kernel.py
pytest tests/test_transform.py
tests/test_model.py
and runpytest tests/test_model.py
.