ENYO-5271: Add debugging utilities to core/handle #1652
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enact-DCO-1.0-Signed-off-by: Ryan Duffy ([email protected])
Enact-DCO-1.0-Signed-off-by: Ryan Duffy ([email protected])
Enact-DCO-1.0-Signed-off-by: Ryan Duffy ([email protected])
Enact-DCO-1.0-Signed-off-by: Ryan Duffy ([email protected])
Enact-DCO-1.0-Signed-off-by: Ryan Duffy ([email protected])
Enact-DCO-1.0-Signed-off-by: Ryan Duffy ([email protected])
Enact-DCO-1.0-Signed-off-by: Ryan Duffy ([email protected])
webOS101
reviewed
May 18, 2018
| * // development tool call stacks | ||
| * // | ||
| * // this.handleKeyDown = logEnter.bind(this) | ||
| * logEnter.bindAs(this, 'handleKeyDown'); |
There was a problem hiding this comment.
Where does Aha, above. It was redundant here, I guess?logEnter come from?
This was referenced Aug 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Resolved / Feature Added
Debugging
core/handleusage can be frustrating when everything is namedanonymous.Resolution
named()to handlers to provide a means to name them when dev tools can't figure it outbindAs()to handlers to combine binding and naming when usingcore/handlewith ES6 classesui/Touchablewhich is used everyone and could benefit from the naming the mostAdditional Considerations
See ariya/phantomjs#14310 for why the
try/catchblock exists :( Its__DEV__only so a minor inconvenience.Enact-DCO-1.0-Signed-off-by: Ryan Duffy ([email protected])