Skip to content
This repository has been archived by the owner on Nov 10, 2022. It is now read-only.

Add deployment configuration file #1

Merged
merged 2 commits into from
Sep 4, 2020

Conversation

ueno
Copy link
Contributor

@ueno ueno commented Aug 28, 2020

This adds support for deployment configuration file, read through the resource bundle.
It currently lacks automated tests, but use the following for manual testing:

$ cp ../wasmtime/tests/wasm/hello_wasi_snapshot1.wat .
$ wat2wasm hello_wasi_snapshot1.wat -o hello.wasm

# attach the configuration to the Wasm file
$ find fixtures/bundle -type f | \
  cargo run --bin enarx-wasmres -- --prefix fixtures/bundle \
  hello.wasm hello-bundled.wasm

# run the bundled Wasm file
$ cargo run --bin enarx-wasmldr hello-bundled.wasm

You will see stdout.txt is created with "Hello world!".

Fixes: enarx/enarx#822
Fixes: enarx/enarx#661

@ueno ueno force-pushed the wip/dueno/cfg branch 3 times, most recently from f3c436c to c665848 Compare August 28, 2020 11:32
@ueno ueno marked this pull request as ready for review August 28, 2020 14:07
@ueno
Copy link
Contributor Author

ueno commented Sep 1, 2020

The following should be fixed:

  • unnecessary copies from the bundled resource
  • attach stdin to a bundled resource
  • lack of tests

@mbestavros mbestavros requested a review from MikeCamel September 1, 2020 14:20
@ueno ueno force-pushed the wip/dueno/cfg branch 3 times, most recently from 1a01bf1 to a7342e4 Compare September 2, 2020 08:27
@npmccallum
Copy link
Contributor

I had some minor nits. But I want to play with this over the weekend. So let's merge it sooner.

@npmccallum npmccallum merged commit 9577e0e into enarx-archive:master Sep 4, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add deployment config to keep runtime enarx-keep-sgx-shim: stdio fd inspection
5 participants