This repository has been archived by the owner on Jul 16, 2020. It is now read-only.
Correct stack alignment calculation #44
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously align_offset(STACK_ALIGNMENT) was substracted, which is wrong, because the documentation states: > Computes the offset that needs to be applied to the pointer in > order to make it aligned. This patch first substracts STACK_ALIGNMENT and then adds align_offset(STACK_ALIGNMENT), if the stack was not yet aligned Also calculating the top with .add(stack.len() - 1) so the stack pointer points initially to a valid memory address.
haraldh
force-pushed
the
stack_alignment
branch
from
9af7bb4 to
2aa88fc
Compare
|
Update: Also calculating the top with .add(stack.len() - 1) so the stack pointer points initially to a valid memory address. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously align_offset(STACK_ALIGNMENT) was substracted, which is
wrong, because the documentation states:
This patch first substracts STACK_ALIGNMENT and then adds
align_offset(STACK_ALIGNMENT), if the stack was not yet aligned