Skip to content

Commit

Permalink
Add error info for external task incomplete
Browse files Browse the repository at this point in the history
From UI it is not clear what is going on with external tasks that fail.
This adds a message to explain the data-missing failure.
  • Loading branch information
davemt committed Dec 8, 2015
1 parent ddaf34b commit fa252fe
Showing 1 changed file with 6 additions and 1 deletion.
7 changes: 6 additions & 1 deletion luigi/worker.py
Original file line number Diff line number Diff line change
Expand Up @@ -161,7 +161,12 @@ def run(self):
# External task
# TODO(erikbern): We should check for task completeness after non-external tasks too!
# This will resolve #814 and make things a lot more consistent
status = DONE if self.task.complete() else FAILED
if self.task.complete():
status = DONE
else:
status = FAILED
expl = 'Task is an external data dependency ' \
'and data does not exist (yet?).'
else:
new_deps = self._run_get_new_deps()
status = DONE if not new_deps else PENDING
Expand Down

0 comments on commit fa252fe

Please sign in to comment.