Raise assertion error if calling .save() on a serializer with errors. C…

…loses #2098.
encode · Dec 2, 2014 · 79e18a2 · 79e18a2
1 parent 6ac79b8
commit 79e18a2
Showing 1 changed file with 8 additions and 0 deletions.
diff --git a/rest_framework/serializers.py b/rest_framework/serializers.py
@@ -127,6 +127,14 @@ def save(self, **kwargs):
             (self.__class__.__module__, self.__class__.__name__)
         )
 
+        assert hasattr(self, '_errors'), (
+            'You must call `.is_valid()` before calling `.save()`.'
+        )
+
+        assert not self.errors, (
+            'You cannot call `.save()` on a serializer with invalid data.'
+        )
+
         validated_data = dict(
             list(self.validated_data.items()) +
             list(kwargs.items())